Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Doctrine\DBAL\Types\Type::__toString() #3257

Merged
merged 1 commit into from
Aug 18, 2018
Merged

Remove Doctrine\DBAL\Types\Type::__toString() #3257

merged 1 commit into from
Aug 18, 2018

Conversation

Majkl578
Copy link
Contributor

@Majkl578 Majkl578 commented Aug 17, 2018 •
edited
Loading

Q A
Type improvement
BC Break yes

Summary

Relying on __toString() internally was already removed in #2835, it's not obsolete and untested API.

1st step towards #2841 (Refactoring type system).

@Majkl578 Majkl578 requested a review from morozov August 17, 2018 20:33
@Majkl578 Majkl578 mentioned this pull request Aug 17, 2018
Merged
@morozov morozov self-assigned this Aug 18, 2018
morozov
morozov approved these changes Aug 18, 2018
View reviewed changes
Copy link
Member

@morozov morozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if relying on FQCN is any better than relying on a made-up name but __toString() shouldn't bepart of the API in any event.

@morozov morozov merged commit b59f84b into doctrine:develop Aug 18, 2018
@morozov morozov added this to the 3.0.0 milestone Aug 18, 2018
@Majkl578 Majkl578 deleted the dev/removal/Type-__toString branch August 18, 2018 19:31
morozov added a commit that referenced this pull request Sep 29, 2018
@morozov
Merge pull request #3257 from Majkl578/dev/removal/Type-__toString
9f218b6 
Remove Doctrine\DBAL\Types\Type::__toString()
morozov added a commit that referenced this pull request Oct 7, 2018
@morozov
Merge pull request #3257 from Majkl578/dev/removal/Type-__toString
2e352ac 
Remove Doctrine\DBAL\Types\Type::__toString()
morozov added a commit that referenced this pull request Oct 7, 2018
@morozov
Merge pull request #3257 from Majkl578/dev/removal/Type-__toString
868c4dc 
Remove Doctrine\DBAL\Types\Type::__toString()
morozov added a commit that referenced this pull request Nov 14, 2018
@morozov
Merge pull request #3257 from Majkl578/dev/removal/Type-__toString
5edd0ee 
Remove Doctrine\DBAL\Types\Type::__toString()
morozov added a commit that referenced this pull request Nov 14, 2018
@morozov
Merge pull request #3257 from Majkl578/dev/removal/Type-__toString
ced6b6e 
Remove Doctrine\DBAL\Types\Type::__toString()
morozov added a commit that referenced this pull request Nov 25, 2018
@morozov
Merge pull request #3257 from Majkl578/dev/removal/Type-__toString
b7e8230 
Remove Doctrine\DBAL\Types\Type::__toString()
morozov added a commit that referenced this pull request Dec 6, 2018
@morozov
Merge pull request #3257 from Majkl578/dev/removal/Type-__toString
dcf864e 
Remove Doctrine\DBAL\Types\Type::__toString()
morozov added a commit that referenced this pull request Jan 20, 2019
@morozov
Merge pull request #3257 from Majkl578/dev/removal/Type-__toString
67a10cd 
Remove Doctrine\DBAL\Types\Type::__toString()
morozov added a commit to morozov/dbal that referenced this pull request Feb 6, 2019
@morozov
Merge pull request doctrine#3257 from Majkl578/dev/removal/Type-__toS…
f7c345f 
…tring

Remove Doctrine\DBAL\Types\Type::__toString()
@morozov morozov mentioned this pull request May 23, 2019
Merged
1 task
@morozov morozov mentioned this pull request Jun 17, 2020
Merged
2 tasks
@morozov morozov modified the milestones: 4.0.0, 3.0.0 Jun 17, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@morozov morozov morozov approved these changes

Assignees

@morozov morozov

Labels
BC Break Improvement Types
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Majkl578 @morozov